Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_exif_date_time_offset: Prioritize QuickTime:ContentCreateDate over EXIF:DateTimeOriginal for videos. #1695

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oPromessa
Copy link
Contributor

I found some videos (from Canon Cameras) which:

  • have EXIF:DateTimeOriginal without offset fields
  • and QuickTime:ContentCreateDate with offset.

With this code change we give priority to QuickTime:ContentCreateDate for videos.

PS: maybe not the most elegant code!

@RhetTbull
Copy link
Owner

@oPromessa Thanks for this. Is there any reason not to just list the QuickTime fields first rather than test for photo/video and construct a list in a different order? Photos won't have the QuickTime:ContentCreateDate so it will be ignored?

Also, in the future, please run black on the code before submitting the PR. This will fix formatting such as mixed use of single and double quotes. I'll add a note to the README_DEV.md about this.

@oPromessa
Copy link
Contributor Author

Let me review.

Will start using black. Thanks for there heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants