Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hfmfview refactor #1942

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DidierA
Copy link
Contributor

@DidierA DidierA commented Mar 13, 2023

Refactor of PR #1926
I added function mfc_read_tag(), which is called in dump and view.

I tested on a MFC 1k card with MAD, however I don't have data to check the vigik part (starting line 6983)

@github-actions
Copy link

You are welcome to add an entry to the CHANGELOG.md as well

@iceman1001
Copy link
Collaborator

its an improvement. I was thinking what if we only make a boolean param for hf mf dump --nosave and guard the "pm3_save" call ...
It would be a much simpler change, where it wouldn't demand reworking the dumping part and adding a lot of params to view command.

@DidierA
Copy link
Contributor Author

DidierA commented Mar 14, 2023

its an improvement. I was thinking what if we only make a boolean param for hf mf dump --nosave and guard the "pm3_save" call ... It would be a much simpler change, where it wouldn't demand reworking the dumping part and adding a lot of params to view command.

Makes sense. And hf mf view could call hf mf dump --nosave when called without -f

@iceman1001
Copy link
Collaborator

Yeah, its a little neat trick.

@iceman1001
Copy link
Collaborator

Lets see,
I used your refactored function, and added the hf mf dump --ns.
Now lets see how this can be done in a nicer way

@DidierA
Copy link
Contributor Author

DidierA commented Apr 13, 2023

Am I missing something? Just updated the firmware to latest and tried hf mf dump --ns. It shows progression about blocks read, then says Called with no save option, and returns. It does not print the card's content to screen ?

@iceman1001
Copy link
Collaborator

should print, shouldn't save...

@iceman1001 iceman1001 closed this Apr 15, 2023
@iceman1001 iceman1001 reopened this Apr 15, 2023
@iceman1001
Copy link
Collaborator

ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants