Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple traffic load balancing among peers #40

Merged
merged 1 commit into from
Jun 3, 2016
Merged

Simple traffic load balancing among peers #40

merged 1 commit into from
Jun 3, 2016

Conversation

nsowen
Copy link
Contributor

@nsowen nsowen commented May 20, 2016

Issue #36: Implemented simple balancing mechanisms based upon the weighted round-robin and weighted least-connections strategies. Weighted least-connections is based on the statistics module and utilizes AppGenRequestPerSecond+NetGenRequestPerSecond. It would be worth actually counting the pending requests in a separate statistic record.

…extensions of client's RouterImpl for basic load balancing support
@deruelle
Copy link
Member

Thanks @nsowen !

@brainslog can you review ?

@brainslog
Copy link
Contributor

Thanks for this contribution @nsowen! Great level of detail in documentation and test coverage, awesome work!

Just a minor tip regarding slf4j, it doesn't require checking if the log level is enabled, since it is cheaper to simply call the logger.<level>(...) method (provided that the params, in case they exist, aren't performing heavy operations).

There are some code-style rules that we will be implementing soon, which will impact these files (2 space indentation, requiring braces where optional, etc.) but we'll fix those when committing the rules.

Thanks, merging.

@brainslog brainslog merged commit 717feb8 into RestComm:master Jun 3, 2016
@deruelle
Copy link
Member

deruelle commented Jun 3, 2016

Thanks for the contribution @nsowen ! Acknowledged at https://telestax.com/acknowledgements/

@nsowen nsowen deleted the peer-loadbalancing branch August 2, 2016 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants