Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't let safe names end with a - #90

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: don't let safe names end with a - #90

merged 1 commit into from
Aug 30, 2024

Conversation

mcmcgrath13
Copy link
Contributor

Ending with a - is an illegal name

gkastrinis
gkastrinis approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@gkastrinis gkastrinis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💪🏼

@mcmcgrath13 mcmcgrath13 merged commit 78b45d3 into master Aug 30, 2024
2 checks passed
@mcmcgrath13 mcmcgrath13 deleted the mcm-fix-safe-no-hyphen branch August 30, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkastrinis gkastrinis gkastrinis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcmcgrath13 @gkastrinis