Thd/ufield #399
Merged
Thd/ufield #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RQ527
requested review from
WhiteNight123,
18445,
985892345,
OkAndGreat,
hiyasame,
owliao,
False-Mask,
RedSun-V,
taolaoge,
Black-Skyline,
Gentlemuqiu,
lytMoon,
flyflowsmallblank and
Faller665
WhiteNight123
approved these changes
Sep 6, 2023
WhiteNight123
previously approved these changes
Sep 6, 2023
# Conflicts: # module_main/src/main/java/com/mredrock/cyxbs/main/adapter/MainAdapter.kt # module_main/src/main/java/com/mredrock/cyxbs/main/ui/main/MainActivity.kt
False-Mask
reviewed
Sep 7, 2023
There was a problem hiding this comment.
更推荐使用viewbinding。郭神封装的view extension模板代码太多了。
|
|
False-Mask
reviewed
Sep 7, 2023
| startActivity.setOnClickListener { | ||
| ServiceManager.activity(UFIELD_ACTIVITY) | ||
| } | ||
| startFood.setOnClickListener { |
There was a problem hiding this comment.
observe的时候设置listener？这里是必须这样写吗，我的理解是create初始化的时候是最优的
False-Mask
reviewed
Sep 7, 2023
| * date : 2023/8/24 11:19 | ||
| */ | ||
| interface ActivityDetailApiService:IApi { | ||
| // companion object { |
False-Mask
reviewed
Sep 7, 2023
|
|
||
| inner class RvDoneViewHolder(itemView: View) : RecyclerView.ViewHolder(itemView) { | ||
|
|
||
| private val actName: TextView = itemView.findViewById(R.id.uField_done_activity_name) |
There was a problem hiding this comment.
虽然可以findViewById但是更推荐使用viewbinding，省去部分模板代码
False-Mask
reviewed
Sep 7, 2023
| // * 满足中心比例的缩放 | ||
| // */ | ||
| // Glide.with(itemView.context) | ||
| // .load(itemData.activity_cover_url) |
RedSun-V
reviewed
Sep 7, 2023
| import kotlinx.coroutines.launch | ||
|
|
||
| /** | ||
| * description ： TODO:类的作用 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
合并中心板块的分支