enable predictions by default

ReactiveBayes · Apr 19, 2024 · 246b196 · 246b196 · bvdmitri · Apr 19, 2024
1 parent c9b09e7
commit 246b196
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "RxInfer"
 uuid = "86711068-29c9-4ff7-b620-ae75d7495b3d"
 authors = ["Bagaev Dmitry <[email protected]> and contributors"]
-version = "3.0.1"
+version = "3.0.2"
 
 [deps]
 BayesBase = "b4ee3484-f114-42fe-b91c-797d54a0c67e"

diff --git a/codemeta.json b/codemeta.json
@@ -9,12 +9,12 @@
     "downloadUrl": "https://github.com/reactivebayes/RxInfer.jl/releases",
     "issueTracker": "https://github.com/reactivebayes/RxInfer.jl/issues",
     "name": "RxInfer.jl",
-    "version": "3.0.1",
+    "version": "3.0.2",
     "description": "Julia package for automated, scalable and efficient Bayesian inference on factor graphs with reactive message passing. ",
     "applicationCategory": "Statistics",
     "developmentStatus": "active",
     "readme": "https://reactivebayes.github.io/RxInfer.jl/stable/",
-    "softwareVersion": "3.0.1",
+    "softwareVersion": "3.0.2",
     "keywords": [
         "Bayesian inference",
         "message passing",

diff --git a/src/model/plugins/reactivemp_inference.jl b/src/model/plugins/reactivemp_inference.jl
@@ -175,7 +175,6 @@ function activate_rmp_variable!(plugin::ReactiveMPInferencePlugin, model::Model,
         options = ReactiveMP.RandomVariableActivationOptions(Rocket.getscheduler(getoptions(plugin)), messages_prod_fn, marginal_prod_fn)
         return ReactiveMP.activate!(getextra(nodedata, ReactiveMPExtraVariableKey)::RandomVariable, options)
     elseif is_data(nodeproperties)
-        # TODO: bvdmitri use allow_missings
         properties = getproperties(nodedata)::GraphPPL.VariableNodeProperties
         # The datavar can be linked to another variable via a `transform` function, which should be stored in the `value` 
         # field of the properties. In this case the `datavar` gets its values from the linked variable and does not create an explicit factor node
@@ -187,7 +186,7 @@ function activate_rmp_variable!(plugin::ReactiveMPInferencePlugin, model::Model,
             transform = _transform
             args = map(arg -> GraphPPL.is_nodelabel(arg) ? getvariable(getvarref(model, arg)) : arg, _args)
         end
-        options = ReactiveMP.DataVariableActivationOptions(false, !isnothing(value), transform, args)
+        options = ReactiveMP.DataVariableActivationOptions(true, !isnothing(value), transform, args)
         return ReactiveMP.activate!(getextra(nodedata, ReactiveMPExtraVariableKey)::DataVariable, options)
     elseif is_constant(nodeproperties)
         # The constant does not require extra activation