Added the option SkipCertificateCheck for self-signed certificates #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, any issues with this change? would be great to get that merged. Regards Dave |
|
Hey, again, just to give you ping. Would be great to merge this stuff into your repo. Please let me know, if i can support you by doing this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
based on issue #45 i added the option "SkipCertificateCheck" to all functions. I hope it's all fine, i am not the god-mode-powersheller. Let me know if something must changed.
I tested it against a RabbitMQ instance with Version 3.9.1. with the alpine-management container. The self-signed certicates are created with openssl.
SSLSUBJECT="/C=$CRT_C/ST=$CRT_S/L=$CRT_L/O=$CRT_OU/CN=$CRT_CN"
openssl req -x509 -newkey rsa:${CRT_LENGTH} -keyout /home/appuser/data/certificates/key.key -out /home/appuser/data/certificates/cer.crt -days $CRT_VALIDITY -nodes -subj "$SSLSUBJECT"