Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Main Thread Checker #24

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Dec 5, 2023

Fixes #22

@madsmtm madsmtm force-pushed the apple-main-thread-checker branch 2 times, most recently from 0984e25 to e06f191 Compare December 7, 2023 03:17
Cargo.toml Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
Copy link
Owner

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! There's still one point I am a bit confused about but I am also fine leaving this as-is. Please squash the commits.

src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@RalfJung RalfJung merged commit 5e04a36 into RalfJung:master Jan 15, 2024
7 checks passed
@madsmtm madsmtm deleted the apple-main-thread-checker branch January 15, 2024 12:26
@madsmtm
Copy link
Contributor Author

madsmtm commented Jan 15, 2024

Thanks for your attention to detail!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Enable main thread checking on Apple platforms
2 participants