Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RailsEventStore and contribs dependency on RubyEventStore::ActiveRecord #1493

Closed
wants to merge 30 commits into from

Conversation

lukaszreszke
Copy link
Contributor

@lukaszreszke lukaszreszke commented Dec 8, 2022

@lukaszreszke lukaszreszke added this to the v3.0.0 milestone Dec 8, 2022
@lukaszreszke
Copy link
Contributor Author

rel: #1439

mostlyobvious and others added 27 commits January 30, 2023 14:29
Since we have introduced AggregateRoot::Repository it is
easy to pass event store as a dependency there. No need
to use AggregateRoot::Configuration and default_event_store.

Make it explicte which event store is used. Less "magic".
* no sane way to support event type scheme for extract last part
* no sane way to normalize every event type to method name
Breaks backwards compatibility, so to be merged with RES 3.x.

We may also consider adding some configuration option to turn it off.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename RailsEventStoreActiveRecord into RubyEventStore::ActiveRecord
4 participants