channel: Increase grace period for subprocesses to stop #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were complaints that tbot would raise the "some subprocess(es) did not stop" error too quickly. The previous 1.27s timeout was too short for some programs to exit on their own. To make tbot more graceful, increase the maximum termination time to 10.2 seconds. However, a warning will be emitted at 1.27s to let the user know why tbot is waiting. Signed-off-by: Rahix <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #120 +/- ##
==========================================
- Coverage 62.39% 62.26% -0.14%
==========================================
Files 53 53
Lines 3755 3747 -8
==========================================
- Hits 2343 2333 -10
- Misses 1412 1414 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were complaints that tbot would raise the "some subprocess(es) did not stop" error too quickly. The previous 1.27s timeout was too short for some programs to exit on their own.
To make tbot more graceful, increase the maximum termination time to 10.2 seconds. However, a warning will be emitted at 1.27s to let the user know why tbot is waiting.
Fixes: #116
Cc: @VictorEmelin