machine: u-boot: Proper exception when retcode parsing fails

Similar to commit b10aceb ("machine: linux: Proper exception when retcode parsing fails"), improve the exception that is thrown when parsing of a command's return code fails. Signed-off-by: Rahix <[email protected]>
Rahix · Feb 16, 2024 · d078f32 · d078f32
1 parent b10aceb
commit d078f32
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/tbot/machine/board/uboot.py b/tbot/machine/board/uboot.py
@@ -276,9 +276,13 @@ def exec(self, *args: ArgTypes) -> typing.Tuple[int, str]:
             ev.data["stdout"] = out
 
             self.ch.sendline("echo $?", read_back=True)
-            retcode = self.ch.read_until_prompt()
+            retcode_str = self.ch.read_until_prompt()
+            try:
+                retcode = int(retcode_str)
+            except ValueError:
+                raise tbot.error.InvalidRetcodeError(self, retcode_str) from None
 
-        return (int(retcode), out)
+        return (retcode, out)
 
     def exec0(self, *args: ArgTypes) -> str:
         """