Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVO-1899: update cython and python versions #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dmzobel
Copy link

@dmzobel dmzobel commented Sep 13, 2024

https://simondata.atlassian.net/browse/DEVO-1899

This change regenerates src files using Cython 0.29.37, which should improve compatibility for later Python versions (3.10-3.11).

This is the process I followed:

  1. Install Cython locally
  2. Run ./update_c.sh from the root of this repository
  3. After noticing the below warnings when running the script, I added # cython: language_level=3 to both src/chat_trie.pxd and src/hat_trie.pyx
/Users/marshall/Library/Python/3.12/lib/python/site-packages/Cython/Compiler/Main.py:369: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /Users/marshall/git/Radico/hat-trie/src/hat_trie.pyx
  tree = Parsing.p_module(s, pxd, full_module_name)
/Users/marshall/Library/Python/3.12/lib/python/site-packages/Cython/Compiler/Main.py:369: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /Users/marshall/git/Radico/hat-trie/src/chat_trie.pxd
  1. Re-ran ./update_c.sh

JRemitz
JRemitz previously approved these changes Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants