Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

774 retrofit combos #775

Open
wants to merge 145 commits into
base: master
Choose a base branch
from
Open

774 retrofit combos #775

wants to merge 145 commits into from

Conversation

FWuellhorst
Copy link
Contributor

@FWuellhorst FWuellhorst commented Oct 4, 2024

@Nico-yf @larissakuehn

Based on the scripts you provided me to retrofit single building elements, I implemented this feature for TEASER. Could one or both of you check if the functions work for you in your lib and review the code? Be aware that you have to switch to the latest TEASER version to check.

Regarding naming of the buildings, I followed your approach, @Nico-yf. We could add an option so that users may define the names based on a callable? E.g. :

def get_retrofit_name(element_retrofit_stats: dict):
    retrofit_name = ''.join(
            f"{element[:2]}{retrofit_dict[retrofit_option]}"
            for element, retrofit_option in element_retrofit_stats.items()
        )
    return retrofit_name

DaJansenGit and others added 30 commits October 26, 2021 16:07
fix typo in e8, bug is already solved in master
* integrate parameters for dynamic heat load calc in modelica

* bump used aixlib version from 1.0.0 to 1.3.1
…responding-subclass

refactor retrofit wall function
hotfix to not insulate when u values are same
[email protected] and others added 28 commits May 29, 2024 07:11
…-will-be-removed-in-a-future-version-please-use-h-instead
…ed-and-will-be-removed-in-a-future-version-please-use-h-instead

fix freq warning in remaining files
…lighting-efficiencies-in-use-conditions

753 add illuminance levels and lighting efficiencies in use conditions
…n-parameters

Deleted obsolte use condition parameters
@@ -477,17 +476,26 @@

@name.setter
def name(self, value):
regex = re.compile('[^a-zA-z0-9]')

Check warning

Code scanning / CodeQL

Overly permissive regular expression range Medium

Suspicious character range that overlaps with a-z in the same character class, and is equivalent to [A-Z\[\]^_`a-z].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants