327 revise ngsi ld batch operation tests #334
Open
+704
−1,647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djs0109
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
@SystemsPurge I merged the test cases of test_ngsi_ld_entities.py intotest_ngsi_ld_cb.py. Let me know whether you have other opinions
| @@ -50,7 +50,7 @@ def setUp(self) -> None: | |||
| 'value': 20.0} | |||
| } | |||
| self.entity = ContextLDEntity(id='urn:ngsi-ld:my:id4', type='MyType', **self.attr) | |||
| self.fiware_header = FiwareLDHeader(ngsild_tenant=settings.FIWARE_SERVICE) | |||
| self.fiware_header = FiwareLDHeader() | |||
There was a problem hiding this comment.
@SystemsPurge why we don't use the value from settings?
|
|
||
| client.entity_batch_operation(action_type=ActionTypeLD.DELETE, entities=entities_a) | ||
| client.entity_batch_operation(action_type=ActionTypeLD.DELETE, entities=entities_b) | ||
| self.assertLessEqual(len(self.client.get_entity_list(limit=1)), 1) |
There was a problem hiding this comment.
Why should these codes be put into the doc strings?
djs0109
requested changes
Oct 22, 2024
| entity_list = self.cb_client.get_entity_list(entity_type=entity_type) | ||
| for entity in entity_list: | ||
| self.cb_client.delete_entity_by_id(entity_id=entity.id) | ||
| entity_list = self.cb_client.get_entity_list(entity_type="filip:object:test") |
There was a problem hiding this comment.
@SystemsPurge, can you use a similar function as in test_ngsi_ld_cb.py?
| range(0, 5)] | ||
|
|
||
| self.cb_client.entity_batch_operation(entities=entities_a, action_type=ActionTypeLD.CREATE) | ||
|
|
||
| entities_update = [ContextLDEntity(id=f"urn:ngsi-ld:test:{str(i)}", | ||
| type=f'filip:object:TypeUpdate') for i in | ||
| type=f'filip:object:test', | ||
| **{'temperature': {'value': self.r.randint(0,20)}}) for i in | ||
| range(3, 6)] |
There was a problem hiding this comment.
Is it on purpose to have an unknown entity here? i.e. urn:ngsi-ld:test:5?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed test duplicates that were present in the test cd ld test file
May not be 100% consistent due to some occasional internal problems in Orion LD that may need to be looked at more closely