Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid spawning multiple of the same Psyonix bot if possible #44

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

NicEastvillage
Copy link
Contributor

No description provided.

@NicEastvillage NicEastvillage added the bug Something isn't working label Aug 8, 2024
Copy link
Collaborator

@VirxEC VirxEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an edge case in here when the unused list is reset midway between getting more psyonix bots there's a chance of one being duplicated. Is it possible to reset & randomize the list every time a match is started? (Doing that near the top of

public static MatchSettingsT GetMatchSettings(string path)
should do it)

@NicEastvillage
Copy link
Contributor Author

Well spotted. Fixed.

Copy link
Collaborator

@VirxEC VirxEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicEastvillage NicEastvillage merged commit b2071a6 into master Aug 9, 2024
2 checks passed
@NicEastvillage NicEastvillage deleted the psyonix_loadouts branch August 9, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants