Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/luid: luid_custom() use fixed width int #20943

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

maribu
Copy link
Member

@maribu maribu commented Oct 28, 2024

Contribution description

This changes the type of the last parameter of luid_custom() to a fixed width integer for consistent behavior among different architectures.

Testing procedure

The unit tests should still pass.

Issues/PRs references

None

@maribu maribu added Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 28, 2024
@github-actions github-actions bot added the Area: sys Area: System label Oct 28, 2024
@riot-ci
Copy link

riot-ci commented Oct 28, 2024

Murdock results

✔️ PASSED

49c151e sys/luid: luid_custom() use fixed width int

Success Failures Total Runtime
10214 0 10215 13m:40s

Artifacts

This changes the type of the last parameter of `luid_custom()` to a
fixed width integer for consistent behavior among different
architectures.
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks!

@mguetschow mguetschow added this pull request to the merge queue Oct 29, 2024
Merged via the queue into RIOT-OS:master with commit 94bb7b2 Oct 29, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants