Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcoap: fix build with IPv4 #20933

Merged
merged 1 commit into from
Oct 24, 2024
Merged

gcoap: fix build with IPv4 #20933

merged 1 commit into from
Oct 24, 2024

Conversation

benpicco
Copy link
Contributor

Contribution description

The debug output breaks the build when compiled with IPv4 support.

Testing procedure

make -C examples/gcoap LWIP_IPV4=1 should work again.

Issues/PRs references

@github-actions github-actions bot added Area: network Area: Networking Area: CoAP Area: Constrained Application Protocol implementations Area: sys Area: System labels Oct 22, 2024
@benpicco benpicco added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 22, 2024
@riot-ci
Copy link

riot-ci commented Oct 22, 2024

Murdock results

✔️ PASSED

ce6d753 gcoap: fix build with IPv4

Success Failures Total Runtime
10215 0 10215 14m:35s

Artifacts

mguetschow
mguetschow previously requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, minor suggestion below.

sys/net/application_layer/gcoap/gcoap.c Show resolved Hide resolved
@maribu
Copy link
Member

maribu commented Oct 22, 2024

Maybe we could introduce a helper than formats a socket endpoint to a string?

Printing IPv addresses without knowing is a pretty handly for debugging/logging even besides this app.

@benpicco
Copy link
Contributor Author

Indeed, something like sock_tl_ep2str() would be nice to have

@benpicco benpicco dismissed mguetschow’s stale review October 24, 2024 09:28

let's clean this up after the release

@mguetschow mguetschow added this pull request to the merge queue Oct 24, 2024
Merged via the queue into RIOT-OS:master with commit fbde020 Oct 24, 2024
34 checks passed
@benpicco benpicco deleted the sys/net/application_layer/gcoap-ipv4 branch October 24, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetschow mguetschow mguetschow left review comments

@maribu maribu maribu approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@chrysn chrysn Awaiting requested review from chrysn

Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @maribu @mguetschow