Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/net/app/cord: update doc #20921

Merged
merged 2 commits into from
Oct 24, 2024
Merged

sys/net/app/cord: update doc #20921

merged 2 commits into from
Oct 24, 2024

Conversation

Vjorald
Copy link
Contributor

@Vjorald Vjorald commented Oct 18, 2024

Contribution description

This PR updates the doc file of the CORD module and examples in RIOT. Updates:

  • Update of the references to RFC 9176.
  • Removal of the label Not Yet Implemented in the doc file of the CORD module, since it is obsolete.

Testing procedure

  • The draft-ietf-core-resource-directory-27 was compared with the RFC 9176 and no necessary changes in the implementation were found.
  • An experimental Lookup Client was built, to test if the functions from the cord_lc of the CORD module in RIOT were implemented. Lookup requests were sent to an aiocoap Resource Directory implementation. All the functions in the cord_lc returned the expected results.

Issues/PRs references

@github-actions github-actions bot added Area: network Area: Networking Area: doc Area: Documentation Area: sys Area: System Area: examples Area: Example Applications labels Oct 18, 2024
@benpicco benpicco requested a review from chrysn October 18, 2024 13:30
Copy link
Member

@chrysn chrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update; let's clear the one comment and then this can go in.

sys/net/application_layer/cord/doc.txt Outdated Show resolved Hide resolved
@mguetschow mguetschow added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 18, 2024
@riot-ci
Copy link

riot-ci commented Oct 18, 2024

Murdock results

✔️ PASSED

d2600f8 cord/doc: Remove the label (Not Yet Implemented) and the group part

Success Failures Total Runtime
1 0 1 01m:17s

Artifacts

@chrysn
Copy link
Member

chrysn commented Oct 18, 2024

Looks good, thanks. Please squash (either into one commit, or into the "update reference" and a "remove label" commit), and prefix them with "cord/doc:" or similar as per the project's convention.

@benpicco benpicco added this pull request to the merge queue Oct 24, 2024
Merged via the queue into RIOT-OS:master with commit ae36fa4 Oct 24, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation Area: examples Area: Example Applications Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants