Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_sixlowpan_frag: Initial import of a fragment size hint feature #11061

Merged
merged 1 commit into from
May 28, 2019
Merged

gnrc_sixlowpan_frag: Initial import of a fragment size hint feature #11061

merged 1 commit into from
May 28, 2019

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Feb 25, 2019 •
edited
Loading

Contribution description

This allows for sending of fragments smaller than the restrictions set by the link-layer PDU. E.g. to put some slack for IPHC into the first fragment (see https://tools.ietf.org/html/draft-ietf-6lo-fragment-recovery-02#section-4.1).

Testing procedure

Currently there is no test for this (I will provide a test application for my minimal fragment forwarding implementation that also tests this feature), so just compiling gnrc_networking with the gnrc_sixlowpan_frag_hint pseudo-module for a 6Lo-capable board (e.g. samr21-xpro) should suffice (this will not be done by the CI!).

Issues/PRs references

Depends on #11021 (mainly because there is a lot of conflict between those two, but functionally it is independent from that PR).

Route to 6Lo minimal fragment forwarding

@miri64 miri64 added Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT State: waiting for other PR State: The PR requires another PR to be merged first labels Feb 25, 2019
@miri64 miri64 added this to the Release 2019.04 milestone Feb 25, 2019
@miri64 miri64 mentioned this pull request Feb 26, 2019
Merged
@miri64
Copy link
Member Author

miri64 commented Mar 29, 2019 •
edited
Loading

#11068 is too experimental so it doesn't make any sense to try to get this into the release => post-poned.

@miri64 miri64 removed this from the Release 2019.04 milestone Mar 29, 2019
@miri64 miri64 force-pushed the gnrc_sixlowpan_frag/new/hint branch from f7f6808 to 42903e5 Compare March 29, 2019 11:36
@miri64
Copy link
Member Author

miri64 commented Mar 29, 2019

Rebased however to resolve conflict with current master

@miri64 miri64 force-pushed the gnrc_sixlowpan_frag/new/hint branch from 42903e5 to 8dd85ce Compare April 18, 2019 14:43
@miri64
Copy link
Member Author

miri64 commented Apr 18, 2019

Rebased to current master and dependencies

@miri64
Copy link
Member Author

miri64 commented Apr 18, 2019

Rebased to current master and dependencies.

@miri64 miri64 force-pushed the gnrc_sixlowpan_frag/new/hint branch from 8dd85ce to 26af0ea Compare May 27, 2019 11:25
@miri64
Copy link
Member Author

miri64 commented May 27, 2019

Rebased to current master.

cgundogan
cgundogan reviewed May 28, 2019
View reviewed changes
sys/include/net/gnrc/sixlowpan/frag.h Outdated Show resolved Hide resolved
sys/include/net/gnrc/sixlowpan/frag/hint.h Outdated Show resolved Hide resolved
@miri64
Copy link
Member Author

miri64 commented May 28, 2019

Reworded the unclear lines.

@miri64 miri64 force-pushed the gnrc_sixlowpan_frag/new/hint branch 2 times, most recently from 098f847 to 5486814 Compare May 28, 2019 17:37
@miri64
Copy link
Member Author

miri64 commented May 28, 2019

Sorry, accidentally pushed an old version -.-

@miri64
Copy link
Member Author

miri64 commented May 28, 2019

(it is fixed now)

cgundogan
cgundogan reviewed May 28, 2019
View reviewed changes
sys/include/net/gnrc/sixlowpan/frag.h Outdated
@@ -94,6 +97,13 @@ typedef struct {
uint16_t tag; /**< Tag used for the fragment */
uint16_t offset; /**< Offset of the Nth fragment from the beginning of the
* payload datagram */
#ifdef MODULE_GNRC_SIXLOWPAN_FRAG_HINT
/**
* @brief Hint for the size (smaller than link-layer PDU) of for the next
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of for? (:

cgundogan
cgundogan approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks okay and compiles without errors using the new pseudomodule. ACK.

@cgundogan cgundogan added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels May 28, 2019
@miri64
gnrc_sixlowpan_frag: Initial import of a fragment size hint feature
2534cfb 
This allows for sending of fragments smaller than the restrictions set
by the link-layer PDU. E.g. to put some slack for IPHC into the first
fragment (see https://tools.ietf.org/html/draft-ietf-6lo-fragment-recovery-02#section-4.1).
@miri64 miri64 force-pushed the gnrc_sixlowpan_frag/new/hint branch from b6bf984 to 2534cfb Compare May 28, 2019 19:04
@cgundogan cgundogan self-requested a review May 28, 2019 19:05
@cgundogan cgundogan added Area: CI Area: Continuous Integration of RIOT components and removed State: waiting for other PR State: The PR requires another PR to be merged first labels May 28, 2019
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed Area: CI Area: Continuous Integration of RIOT components labels May 28, 2019
@cgundogan cgundogan merged commit 3f4259a into RIOT-OS:master May 28, 2019
@miri64 miri64 deleted the gnrc_sixlowpan_frag/new/hint branch May 28, 2019 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgundogan cgundogan cgundogan approved these changes

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @cgundogan