Add recipe for FLINT C library #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now in Rtools (r6346) and upstream MXE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from our e-mail thread ("Re: Adding FLINT ..."):
Tomas and I have made progress preparing FLINT for MXE and Rtools, along the way requesting some improvements to FLINT's build system:
mxe/mxe#3116
flintlib/flint#2077
flintlib/flint#2097
It is planned that these changes will be included in the next FLINT release, so I'm hopeful that we can forge ahead with adding a recipe here. This PR aims to provide a working recipe and to document relevant issues.
The recipe in the PR uses
Special: in-sourcesto temporarily work around the fact that building out of tree is not supported in the current FLINT release. That can be removed as soon as it becomes possible to upgrade.The patch file in the PR resolves a bug in the library's tests causing
make checkto fail with a linker error. I observe the error locally (Xcode 15), but none of their runners reproduce it. (There are macOS runners but they may not be using the native toolchain.) The patch file is optional for the build itself and should become redundant soon enough:flintlib/flint#2058
Under Xcode 14,
make checkwas seen to fail at an earlier stage because Apple Clang was producing wrong assembly for one of the tests. That seems to be fixed in Xcode 15.flintlib/flint#2048
IIUC, Xcode 14 is still used to build R binaries and external libraries for macOS. There is no evidence yet that this issue affects the functionality of my R package, though that could change as the interface and test suite grow. Well, by that time, you may already have moved to Xcode 15 ...