chore: merge main into v2 #6816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes imports-of-imports and is also much nicer for debugging
this also protects it against dangling symlinks
* fix: fix a ts issue * fix: fix a ts issue * fix: fix a ts issue * fix: fix a ts issue --------- Co-authored-by: wuls <[email protected]>
* add possibility to define multiple outputs in vite * more explicit assertions in tests * simplify code * small improvement to make sure at least one output is present in every case * change variable name so the history is easier to follow * fix(vite.unit.ts): grab plugin --------- Co-authored-by: PatrickJS <[email protected]>
I changed the references to install directly from github to the right repository Co-authored-by: Tobias Zimmermann <[email protected]>
comment out footer sponsors on homepage
… for dev server (#6427)
* refactor: remove references to `currentScript` `currentScript` is not available in shadow dom. For this reason we can't use it. This change removes all references to `currentScript` The biggest change is that the `qFuncs` are no longer written to the container element but rather to the document. Because there is only one document the `qFuncs` property now includes the `container` `q:manifest-hash` to distinguish between different containers. * fixup! refactor: remove references to `currentScript`
- click to file works again - don't duplicate code DOM elements - in mobile, put file paths at the top And most notably: - store now deeply updates so that code changes update the output
- refactored manifest generation - dev server collects QRL parents during ssr build - optimizer also stores dev info for noop QRLs - dev server also uses dev info as an extra fallback - dev source URLs are kept similar looking to the source tree - QRLs are annotated with parent so they can be built on demand
Shadow DOM can be used to isolate an application. The isolation also
includes:
- Events don't bubble across shadow boundaries.
- QuerySelector doesn't cross shadow boundaries.
QwikLoader relies on both event bubbling and querySelector to process
events such as `on:click` and dispatch such as `on-window:resize`.
To enable QwikLoader to work with shadow DOM, it is necessary to tell
qwikloader that when it is registering an event listener, as well as
performing querySelector, it should do so not just on document but also
inside the shadow DOM. To do that it is the responsibility of the
developer to tell qwikloader about the shadow DOM roots.
CONSTRAINTS:
The qwikloader applications `q:container` must be fully inside the
shadow root. (i.e. the application itself must not cross the shadow DOM
boundaries.)
Developer responsibility: (choose one)
- Have qwik loader find the roots by annotate the elements which have
shadow DOM with `q:shadowRoot` attribute.
- Manually insert a `<script>` tag into HTML which will add the shadow DOM
root into the qwikloader's `qwikevents` array.
Example:
Possible implementation
```html
<div id="my-child" q:shadowRoot>
<template shadowrootmode="open">
<div q:container="..." q:base="..."...>qwik-container here</div>
</template>
</div>
```
Fixes: #6546
Co-authored-by: Giorgio Boa <[email protected]>
- now you can call the result of `.resolve()` (and `.resolved`) directly - avoids wrapping QRL functions that don't use lexical scope
Co-authored-by: PatrickJS <[email protected]> Co-authored-by: PatrickJS <[email protected]> Co-authored-by: Wout Mertens <[email protected]>
Co-authored-by: Giorgio Boa <[email protected]>
🦋 Changeset detectedLatest commit: 97676d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
this is used to enforce the import rules
Co-authored-by: Wout Mertens <[email protected]>
Varixo
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very heavy lift. The Rust optimizer changes are extra-verified by me, and you can see by the snapshots that they're ok.
The rest of the changes need the tests to verify that they're ok.