chore: Remove undici, set minimum node version to 18.17 #5702
Conversation
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | Google API Key | 1d9fa88 | packages/docs/scripts/showcase.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
wmertens
force-pushed
the
remove-undici
branch
3 times, most recently
from
ca09a42
to
1681c2b
Compare
|
When will this change be merged? |
wmertens
force-pushed
the
remove-undici
branch
from
1681c2b
to
344a776
Compare
wmertens
force-pushed
the
remove-undici
branch
from
344a776
to
25ab136
Compare
|
@manucorporat the macro plugin keeps erroring on insights/src/root.tsx, even though it hasn't changed. It says the code is unreachable. Any idea what could cause this? |
|
can we change the min version to node 20? 😁 20 is a lot faster |
|
is this PR still valid or is it abandoned ? |
If I am not mistaken they are waiting for version 2.0. |
The node engines "^18.17.0 || ^20.3.0 || >=21.0.0" are taken from the `sharp` dependency, which probably has good reason for them. All of these include global fetch, so undici is not needed. Bun and deno also include fetch.
|
sharprequires "^18.17.0 || ^20.3.0 || >=21.0.0", and that's the cause of installation issues.Furthermore, global fetch is in node since v18, so we don't need undici any more.
Bun and Deno also include fetch.