log-server: tweak Store API, add SQLiteStore tests

.changeset/curvy-cycles-crash.md

@@ -0,0 +1,5 @@
+---
+'@lightmill/log-server': major
+---
+
+Rename Store#addRunLogs to Store#addLogs.

.changeset/shaggy-dancers-wait.md

@@ -0,0 +1,5 @@
+---
+'@lightmill/log-server': major
+---
+
+Stop sorting logs per type with SQLiteStore#getLogs. Creation date is more relevant. Also update the corresponding database index.

.changeset/thin-snakes-dance.md

@@ -0,0 +1,5 @@
+---
+'@lightmill/log-server': major
+---
+
+Store#addLogs now requires a createdAt property for each log

packages/log-server/__tests__/app.test.ts

@@ -30,7 +30,7 @@ function MockStore(): MockStore {
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     setRunStatus: vi.fn((...args) => Promise.resolve()),
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    addRunLogs: vi.fn((...args) => Promise.resolve()),
+    addLogs: vi.fn((...args) => Promise.resolve()),
     getLogValueNames: vi.fn(() =>
       Promise.resolve(['mock-col1', 'mock-col2', 'mock-col3']),
     ),
@@ -378,7 +378,7 @@ describe('/experiments/runs/logs', () => {
   describe('post /experiments/:experiment/runs/:run/logs', () => {
     beforeEach(async () => {
       vi.useFakeTimers({ toFake: ['Date'] });
-      vi.setSystemTime(1234567890);
+      vi.setSystemTime(100100);
       store = MockStore();
       let app = createLogServer({
         store,
@@ -412,7 +412,7 @@ describe('/experiments/runs/logs', () => {
           message:
             'Client does not have permission to add logs to run "not-my-run" of experiment "test-exp"',
         });
-      expect(store.addRunLogs).not.toHaveBeenCalled();
+      expect(store.addLogs).not.toHaveBeenCalled();
     });
 
     it('should add a single log to the run', async () => {
@@ -427,11 +427,12 @@ describe('/experiments/runs/logs', () => {
           },
         } satisfies PostLogsBody)
         .expect(201, { status: 'ok' });
-      expect(store.addRunLogs).toHaveBeenCalledWith('test-exp', 'test-run', [
+      expect(store.addLogs).toHaveBeenCalledWith('test-exp', 'test-run', [
         {
           type: 'test-log',
           values: { p1: 'v1', p2: 'v2' },
           date,
+          createdAt: vi.getMockedSystemTime(),
         },
       ]);
     });
@@ -455,16 +456,18 @@ describe('/experiments/runs/logs', () => {
           ],
         } satisfies PostLogsBody)
         .expect(201, { status: 'ok' });
-      expect(store.addRunLogs).toHaveBeenCalledWith('test-exp', 'test-run', [
+      expect(store.addLogs).toHaveBeenCalledWith('test-exp', 'test-run', [
         {
           type: 'test-log',
           values: { p1: 'v1', p2: 'v2' },
           date: date1,
+          createdAt: vi.getMockedSystemTime(),
         },
         {
           type: 'test-log',
           values: { p3: 'v3', p4: 'v4' },
           date: date2,
+          createdAt: vi.getMockedSystemTime(),
         },
       ]);
     });