Give input focus to globally active clients #168
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This technically violates the ICCCM, but the alternative is not much better: these windows *will* have focus in the GUI qube, so not giving them focus on the agent side will cause the X state to no longer be the same on both sides. Worse, such clients might not be expecting to lose focus without warning. Explicitly taking focus away from them might help. This is based on a similar commit in wlroots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This technically violates the ICCCM, but the alternative is not much
better: these windows will have focus in the GUI qube, so not giving
them focus on the agent side will cause the X state to no longer be the
same on both sides. Worse, such clients might not be expecting to lose
focus without warning. Explicitly taking focus away from them might
help.
This is based on a similar commit in wlroots.