vmupdate: add support for nixos #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will resign this with gpg later |
evq
commented
Sep 19, 2024
| @@ -276,7 +276,10 @@ def upgrade_internal(self, remove_obsolete: bool) -> ProcessResult: | |||
| Just run upgrade via CLI. | |||
| """ | |||
| cmd = [self.package_manager, | |||
| "--noconfirm" if self.package_manager == "pacman" else "-y", | |||
| *( | |||
There was a problem hiding this comment.
i just extended the existing pattern but please let me know if you'd prefer I clean this up in some way. as-is package manager specifics are leaking into this common module.
There was a problem hiding this comment.
This is already fixed in #164, but it waits for resolving conflicts
There was a problem hiding this comment.
FYI the other PR is merged now, you can rebase to resolve the conflict.
marmarek
reviewed
Sep 28, 2024
Comment on lines
228
to
+232
| result.out += self._print_to_string( | ||
| pkg, | ||
| str(changes["updated"][pkg]["old"])[2:-2] | ||
| ", ".join((changes["updated"][pkg]["old"])) | ||
| + " -> " + | ||
| str(changes["updated"][pkg]["new"])[2:-2]) | ||
| ", ".join((changes["updated"][pkg]["new"])) |
There was a problem hiding this comment.
This has a syntax error: not closed (
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds support for nixos updates based on the discussion in QubesOS/qubes-issues#7992.
thanks for all the quick replies and advice @marmarek
notes:
nixos-rebuildflags via the qubes update nix module. the possibility was mentioned that reading flags from a file might be preferred - however it seemed tidier this way and we can instead have the wrapper simply pass it's arguments on tonixos-rebuild.nix store diff-closuresseemed to be the best option however it is designed to diff. e.g. compare the previous system closure to the previous ones. the wrapper script first constructs an empty closure so that we can diff against it. again, it seemed tidier to abstract these details away.