Improve qvm-ls options to avoid parsing #301
Conversation
|
Making pylint happy(er) I am waiting for the CI/CD bot to advise on the required unit tests. |
fixes: QubesOS/qubes-issues#8614 Filtering, Formatting & Sorting ArgumentParser Groups Sorting options based on output columns A new pref(erence) format Dedicated filter options for class, label, template, netvm preferences Dedicated filter options for internal,servicevm & updates-available Generic filtering options for preferences and features
|
Making pylint even happier (complain on assignment of lambda to variable) The CI/CD build failure logs are very cluttered and hard to understand. If it is because of sphinx complain, should be fixable by updating the documents (if the overall changes and new options are acceptable). |
|
TODo: Numeric sort wherever applicable. |
Requested changes by ben-grande (QubesOS#301) Numeric sort if applicable
Follow-up to QubesOS#301 Options are grouped as general, formatting, filtering and sorting
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
+ Coverage 74.81% 75.09% +0.28%
==========================================
Files 52 52
Lines 8440 8541 +101
==========================================
+ Hits 6314 6414 +100
- Misses 2126 2127 +1 ☔ View full report in Codecov by Sentry. |
|
Ok. After updating the documentation, we are past CI/CD bot (all Green) and Codecov is advising on the required unit tests. I will write them next. |
Follow-up to QubesOS#301
Follow-up to QubesOS#301 Plus minor fix for documentation
|
A supplementary commit to implement documentation & commenting improvements based on @ben-grande suggestions |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024082316-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024070519-4.3&flavor=update
Failed tests120 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/105374#dependencies 8 fixed
Unstable tests
|
fixes: QubesOS/qubes-issues#8614
Filtering, Formatting & Sorting ArgumentParser Groups
Sorting options based on output columns
A new pref(erence) format
Dedicated filter options for class, label, template, netvm preferences
Dedicated filter options for internal,servicevm & updates-available
Generic filtering options for preferences and features