Feature: support new config type account-id
#500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Romazes
force-pushed
the
feature-trade-station-new-config-account-number
branch
from
7e9f520
to
94d8067
Compare
feat: skip account ids if it is not provided
refactor: use elif instead of if
Romazes
force-pushed
the
feature-trade-station-new-config-account-number
branch
from
94d8067
to
e7d212f
Compare
11 tasks
refactor: parsing of new object Auth0 test:refactor: use new mock object of Auth0
Martin-Molinero
approved these changes
Oct 1, 2024
Martin-Molinero
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"input-method": "choice"without providing data, bypassing parameter validation. This allows us to initialize the choice in the code as needed.Related PR
account-idLean.Brokerages.TradeStation#27How Has This Been Tested?
Valid
account-idlean live deploy mynewalgo --brokerage TradeStation --trade-station-account-id "SIMXXXXXXXM"Invalid
account-idlean live deploy mynewalgo --brokerage tradestation --data-provider-live tradestation --trade-station-account-id SIMXXX