generated from QuantConnect/Lean.Brokerages.Template
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: multiple subscriptions in DataQueueHandler
#32
Merged
Martin-Molinero
merged 26 commits into
QuantConnect:master
from
Romazes:fix-31-data-queue-handler-multiple-subscriptions
Oct 21, 2024
Merged
Fix: multiple subscriptions in DataQueueHandler
#32
Martin-Molinero
merged 26 commits into
QuantConnect:master
from
Romazes:fix-31-data-queue-handler-multiple-subscriptions
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: handle OperationCanceledException
feat: StreamTaskManager with stream functionally feat: TradeStation Multiple Subscription Manager to subscribe on multiple symbols remove: handle response in DQH partial class
feat: add Dispose to classes
feat: dev friendly comment why skip OperationCanceledException
…onItem refactor: dispose in StreamTaskManager feat: new log about remove subscriptionTask in TradeStationBrokerageMultiStreamSubscriptionManager
feat: add lock to all operation with hash collection in StreamingTaskManager remove: internall list in task
refactor: RemoveSubscriptionItem in StreamingTaskManager refactor: UnSubscribe in TradeStationBrokerageMultiStreamSubscriptionManager
Martin-Molinero
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
When attempting to subscribe to a large number of symbols (over 1,000), an exception was raised:
url is too long
.Solution
This PR addresses the issue by dividing the symbol subscriptions into smaller chunks of 100 symbols each. Each chunk is handled as a separate task, allowing efficient updates from TradeStation without exceeding URL length limits.
Related Issue
closes #31
Motivation and Context
The goal is to enable users to subscribe to a large number of symbols for market analysis based on the returned data. This will help them create more effective algorithms in Lean by providing broader market coverage.
Requires Documentation Change
N/A
How Has This Been Tested?
Test Lean Algrotihm #1
Result:
Test Lean Algrotihm #2
Test Algorithm #3
Testing with Algo from #31. We can see that prices are changed.
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>