update 10/08/24 10:34:27

Qovery · Oct 8, 2024 · fcc101b · fcc101b
1 parent acce5a7
commit fcc101b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 6 deletions.
diff --git a/charts/qovery/values-demo-scaleway.yaml b/charts/qovery/values-demo-scaleway.yaml
@@ -165,9 +165,14 @@ ingress-nginx:
  service.beta.kubernetes.io/scw-loadbalancer-protocol-http: "false"
  service.beta.kubernetes.io/scw-loadbalancer-proxy-protocol-v1: "false"
  service.beta.kubernetes.io/scw-loadbalancer-proxy-protocol-v2: "true"
- # cant enable http checks due to missing annotations to enable proxy protocol on checks
- # https://console.scaleway.com/support/tickets/1423150
- service.beta.kubernetes.io/scw-loadbalancer-health-check-type: tcp
+ # We use http healthcheck for the load balancer to speed up the detection of the instance being down
+ # during termination of the pods.
+ # With TCP healthcheck, the LB is going to keep the instance in the pool as long as the port is open,
+ # even if nginx will refuse new connections, because it is shutting down.
+ # Doing real http healthcheck, will minimize the time the LB will keep the instance in the pool.
+ service.beta.kubernetes.io/scw-loadbalancer-health-check-type: "80:http;443:https"
+ service.beta.kubernetes.io/scw-loadbalancer-health-check-http-uri: "80:/healthz;443:/healthz"
+ service.beta.kubernetes.io/scw-loadbalancer-health-check-send-proxy: "true"
  service.beta.kubernetes.io/scw-loadbalancer-use-hostname: "true"
  service.beta.kubernetes.io/scw-loadbalancer-health-check-delay: "2s"
  service.beta.kubernetes.io/scw-loadbalancer-health-check-timeout: "2s"

diff --git a/charts/qovery/values-scaleway.yaml b/charts/qovery/values-scaleway.yaml
@@ -165,9 +165,14 @@ ingress-nginx:
  service.beta.kubernetes.io/scw-loadbalancer-protocol-http: "false"
  service.beta.kubernetes.io/scw-loadbalancer-proxy-protocol-v1: "false"
  service.beta.kubernetes.io/scw-loadbalancer-proxy-protocol-v2: "true"
- # cant enable http checks due to missing annotations to enable proxy protocol on checks
- # https://console.scaleway.com/support/tickets/1423150
- service.beta.kubernetes.io/scw-loadbalancer-health-check-type: tcp
+ # We use http healthcheck for the load balancer to speed up the detection of the instance being down
+ # during termination of the pods.
+ # With TCP healthcheck, the LB is going to keep the instance in the pool as long as the port is open,
+ # even if nginx will refuse new connections, because it is shutting down.
+ # Doing real http healthcheck, will minimize the time the LB will keep the instance in the pool.
+ service.beta.kubernetes.io/scw-loadbalancer-health-check-type: "80:http;443:https"
+ service.beta.kubernetes.io/scw-loadbalancer-health-check-http-uri: "80:/healthz;443:/healthz"
+ service.beta.kubernetes.io/scw-loadbalancer-health-check-send-proxy: "true"
  service.beta.kubernetes.io/scw-loadbalancer-use-hostname: "true"
  service.beta.kubernetes.io/scw-loadbalancer-health-check-delay: "2s"
  service.beta.kubernetes.io/scw-loadbalancer-health-check-timeout: "2s"