Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md with changes for note plaintext size generalization #6

Merged
merged 2 commits into from
May 16, 2024

Conversation

dmidem
Copy link

@dmidem dmidem commented May 16, 2024

This PR updates the CHANGELOG.md to include the changes related to the note plaintext size generalization under the "Unreleased" section.

@dmidem dmidem requested a review from PaulLaux May 16, 2024 14:24
Copy link

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor adjustments.

CHANGELOG.md Outdated
`CompactNotePlaintextBytes`, and `CompactNoteCiphertextBytes` to `Domain`
trait.
- Updated function signatures to remove constants that are unknown at
compilation time.
Copy link

@PaulLaux PaulLaux May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Generalized the note plaintext size to support variable sizes by adding the abstract types `NotePlaintextBytes`, `NoteCiphertextBytes`, `CompactNotePlaintextBytes`, and `CompactNoteCiphertextBytes` to the `Domain` trait.
- Moved the specific constants into the `Domain` trait implementations.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@dmidem dmidem merged commit 1ca015a into zsa1 May 16, 2024
23 checks passed
@dmidem dmidem deleted the update-changelog branch May 16, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants