Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream diff #4

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Upstream diff #4

wants to merge 8 commits into from

Conversation

PaulLaux
Copy link

No description provided.

dmidem and others added 2 commits December 19, 2023 20:08
* Copy updated src folder from librustzcash/zsa1

* Cherry-pick the latest update of zcash_note_encryption from zcash/librustzcash (it was missed in QED-it/librustzcash)

* Upgrade Rust version

* Upgrade Rust version to 1.65

* Add --features=alloc to command line for build-nodefault jon in ci.yml

* Downgrade Rust version back to 1.61.0

---------

Co-authored-by: Dmitry Demin <[email protected]>
@PaulLaux PaulLaux changed the title Add generalization to support OrchardZSA and AssetBase (#1) Upstream diff Apr 17, 2024
dmidem and others added 6 commits May 16, 2024 16:55
…on (#6)

* Update CHANGELOG.md with changes for note plaintext size generalization

* Improve the description in CHANGELOG.md

---------

Co-authored-by: Dmitry Demin <[email protected]>
Co-authored-by: Dmitry Demin <[email protected]>
)

* Attempt to resolve review issues for zcash/pull/2

* NoteBytes moved to zcash_note_encryption (copy of #8) (#9)

* Add NoteBytes

* Implement concat manually for wasm

* Fix slice bounds in concat

* Fmt

* Split interface and implementation of NoteBytes

* Add new method to NoteBytes

---------

Co-authored-by: alexeykoren <[email protected]>

* Resolve review issues for zcash/pull/2 (except returning references from ShieldedOutput methods)

* Fix cargo doc issue

* Fix based on feedback from PR #10 review

* Make split_ciphertext_at_tag a method of ShieldedOutput with minor refactoring

---------

Co-authored-by: Dmitry Demin <[email protected]>
Co-authored-by: alexeykoren <[email protected]>
* Refactor enc_ciphertext to return reference instead of copy

These changes were discussed and suggested in PR zcash_note_encryption#2

* Remove extra spaces in rust-toolchain.toml

* Restore the original order of const definition to reduce PR diff

* Fix the comment for split_plaintext_at_memo

* Fix docstring for NOTE_PLAINTEXT_SIZE

* Update CHANGELOG

* Remove unused constants COMPACT_NOTE_SIZE, NOTE_PLAINTEXT_SIZE, ENC_CIPHERTEXT_SIZE, and update CHANGELOG accordingly

* Minor improvement in CHANGELOG.md

---------

Co-authored-by: Dmitry Demin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants