Update ErrorAlert

Q42 · May 13, 2024 · 0990582 · 0990582
1 parent 70d0bbc
commit 0990582
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/TemplateApp/Localizable.xcstrings b/TemplateApp/Localizable.xcstrings
@@ -1,12 +1,12 @@
 {
   "sourceLanguage" : "en",
   "strings" : {
-    "Error" : {
+    "An error occurred" : {
       "localizations" : {
         "nl" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Fout"
+            "value" : "Er is een fout opgetreden"
           }
         }
       }
@@ -30,9 +30,6 @@
           }
         }
       }
-    },
-    "Preview error title" : {
-
     },
     "Refresh" : {
       "localizations" : {

diff --git a/TemplateApp/ViewModifiers/ErrorAlert.swift b/TemplateApp/ViewModifiers/ErrorAlert.swift
@@ -11,7 +11,7 @@ import SwiftUI
 extension View {
     /// Presents an alert when an error is present, with custom actions.
     func alert<E: Error, Actions: View>(
-        _ title: LocalizedStringKey?,
+        _ title: LocalizedStringKey,
         error: Binding<E?>,
         @ViewBuilder actions: @escaping () -> Actions
     ) -> some View {
@@ -35,15 +35,15 @@ extension View {
 /// A modifier that presents an alert when an error is present.
 private struct ErrorAlert<E: Error, ActionButton: View>: ViewModifier {
     @Binding var error: E?
-    let title: LocalizedStringKey?
+    let title: LocalizedStringKey
     @ViewBuilder let actions: () -> ActionButton
 
     var isPresented: Bool {
         error != nil
     }
 
     func body(content: Content) -> some View {
-        content.alert(title ?? "Error", isPresented: .constant(isPresented), actions: actions) {
+        content.alert(title, isPresented: .constant(isPresented), actions: actions) {
             Text(error?.localizedDescription ?? "")
         }
     }
@@ -52,7 +52,7 @@ private struct ErrorAlert<E: Error, ActionButton: View>: ViewModifier {
 #Preview("Error alert") {
     let error = TemplateAppError(message: "Failed to load all the things")
     return Text(verbatim: "Preview text")
-        .alert("Preview error title", error: .constant(error)) {
+        .alert("An error occurred", error: .constant(error)) {
             Button("Ok") {}
         }
 }