REPLACE Moshi by Kotlinx serialization #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninovanhooff
changed the title
This allows reverse proxies like Charles to inspect and manipulate traffic in development builds
ninovanhooff
commented
Dec 15, 2023
sebaslogen
previously approved these changes
Dec 21, 2023
core/actionresult/src/main/kotlin/nl/q42/template/actionresult/data/ActionResultMapper.kt
Outdated
Show resolved
Hide resolved
core/network/src/main/kotlin/nl/q42/template/core/network/di/NetworkModule.kt
Show resolved
Hide resolved
data/user/src/main/kotlin/nl/q42/template/data/user/remote/model/UserDTO.kt
Show resolved
Hide resolved
sebaslogen
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this important?
Moshi allows for more programmer error when forgetting to add annotations. Also it needs an extra plugin for sealed classes support and it needs proguard rules
We use Kotlinx.serialization for all json parsing
because it is fast, modern and has IDE integration (which warns you when you forget to add @serializable annotations).
It also has multiplatform support, so we can use it in our KMP projects as well.
Any review notes?
This false positive linting warning. The project runs fine.
For a template project, these warnings might not be acceptable
It seems scheduled to be fixed in intellij 2023.3, which is Android Studio Jellyfish, currently in Nightly (did not test myself)
Strangely, I do not have this issue in the widm project (which uses other versions of kotlin and the gradle plugin, same Android Studio)
https://github.com/Q42/widm-android/blob/689d6e71935f460b2791c73fc505f681b40dcafb/gradle/libs.versions.toml
https://youtrack.jetbrains.com/issue/KTIJ-10755/HMPP-IDE-False-PLUGINISNOTENABLED-in-IDE-for-kotlinx-serialization-plugin-however-project-builds-correctly