ADD Junit testing #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsuijten
previously approved these changes
Aug 11, 2023
Frank1234
previously approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this important?
Unit testing Flows is not always straightforward, let's give an example and set up the dependencies
Any review notes?
Uses Junit java dependencies directly, ie.
import junit.framework.TestCase.assertEqualsI think kotlin-test would be nicer, but I'm not sure how to add the dependency
https://kotlinlang.org/docs/jvm-test-using-junit.html (note this uses junit5 and we are using junit4)
It is unclear whether junit5 is supported in Android, don't think so: https://issuetracker.google.com/issues/127100532