-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes bug with IndexedSet objects and the within argument #3288
Conversation
The tests are failling because of numpy v2, which is being handled already in #3291 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great catch and I am impressed that the fix was that straightforward. I have a couple minor requests for edits (one is a slight modification to your fix, and the other updates the tests to make better / more standard use of unittest).
note that this PR will conflict with #3302. I propose that (assuming you have time), we get this PR updated and merged first and then I will update #3302.
@thisandthatuser - can you please run the following on your code:
If you already have |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3288 +/- ##
=======================================
Coverage 88.48% 88.48%
=======================================
Files 868 868
Lines 98427 98428 +1
=======================================
+ Hits 87095 87097 +2
+ Misses 11332 11331 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fixes #3284 .
Summary/Motivation:
Indexed sets relying on other indexed sets for the within argument trigger errors in pyomo 6.7.3, whereas in pyomo 6.6.x they did not.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: