-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add highs support in MindtPy #2971
Conversation
I think the |
Let's wait for the next release (1.5.4) of |
Highs 1.60 was just released. @blnicho |
This is waiting on highspy 1.6.0 to be released on PyPI. Relevant issue: ERGO-Code/HiGHS#925 and discussion: ERGO-Code/HiGHS#1441 |
Highspy 1.7.1 is available. |
Hi @blnicho. The tests failed after I changed the highs version check from |
You need to put in quotes (otherwise the shell interprets the - $PYTHON_EXE -m pip install --cache-dir cache/pip highspy>=1.7.1.dev1 \
+ $PYTHON_EXE -m pip install --cache-dir cache/pip "highspy>=1.7.1.dev1" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZedongPeng I made a minor change in how the APPSI Highs interface gets the solver version. Hopefully this will resolve the Jenkins test failures. Assuming everything passes I think this is finally ready to be merged. Thanks for your patience!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2971 +/- ##
==========================================
+ Coverage 88.45% 88.47% +0.01%
==========================================
Files 850 850
Lines 95525 95544 +19
==========================================
+ Hits 84500 84531 +31
+ Misses 11025 11013 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
echo "NOTE: temporarily pinning to highspy pre-release for testing" | ||
$PYTHON_EXE -m pip install --cache-dir cache/pip "highspy>=1.7.1.dev1" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove 'temporarily' if this is how we're leaving it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should leave it for now. When they cut a new (non-dev) highspy release we can remove the version requirement.
Fixes #2951 and #2874.
Since the Highs team has fixed the column integrality bug ERGO-Code/HiGHS#1386, mindtpy can now support
appsi_highs
as themip_solver
.Summary/Motivation:
appsi_highs
in MindtPy.mip_solver
fromglpk
toappsi_highs
in MindtPy tests.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: