-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xpress: fix NLP results processing for Xpress 9.2.0 #2921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo!!
elif status == xp.nlp_unfinished: | ||
results.solver.status = SolverStatus.ok | ||
results.solver.termination_message = ( | ||
"Non-convex solve not finished (numerical issues?)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remind me later to change this error message. Because it's entirely not helpful.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2921 +/- ##
==========================================
+ Coverage 87.81% 87.83% +0.01%
==========================================
Files 770 770
Lines 89644 89645 +1
==========================================
+ Hits 78721 78736 +15
+ Misses 10923 10909 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Fixes # .
Summary/Motivation:
Xpress 9.2.0 appears to return infeasible status differently than previous versions. In previous versions, infeasible nonlinear problems solved using the Xpress optimizer returned solution status via
LPSTATUS
. Beginning in 9.2, it appears that the problem status is now returned inXSLP_NLPSTATUS
. This PR updates the results processor to only fall back on the LP results processor ifLPRESULTS
is nonzero (andXSLP_NLPSTATUS
is 0)@djunglas, am I interpreting the change in Xpress behavior correctly?
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: