-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize numeric expression modules #2909
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2909 +/- ##
==========================================
- Coverage 87.81% 87.81% -0.01%
==========================================
Files 770 770
Lines 89626 89642 +16
==========================================
+ Hits 78701 78715 +14
- Misses 10925 10927 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments but otherwise this looks fine
Fixes # .
Summary/Motivation:
This PR starts the process of reorganizing the numeric expression system to reduce the complexity induced by circular imports in the current implementation. This is the first step in a larger update of the expression systems (working toward implementing multiple dispatch for relational and logical expressions).
Changes proposed in this PR:
pyomo.common.errors
value
andcheck_if_numeric_type
topyomo.common.numeric_types
NumericValue
andNumericNDArray
classes intoexpr.numeric_expr
Expr_it
) fromexpr.current
intoexpr.numeric_expr
attempt_import
to break import loopsLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: