Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPSI Interface to WNTR #2902

Merged
merged 18 commits into from
Nov 27, 2023
Merged

APPSI Interface to WNTR #2902

merged 18 commits into from
Nov 27, 2023

Conversation

michaelbynum
Copy link
Contributor

Summary/Motivation:

This PR creates a persistent interface to the Newton solver in WNTR. It only supports square, equality-constrained problems.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (ae85c0c) 87.98% compared to head (b474f2f) 88.01%.

Files Patch % Lines
pyomo/contrib/appsi/solvers/wntr.py 93.52% 22 Missing ⚠️
pyomo/contrib/appsi/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2902      +/-   ##
==========================================
+ Coverage   87.98%   88.01%   +0.03%     
==========================================
  Files         770      771       +1     
  Lines       90242    90583     +341     
==========================================
+ Hits        79400    79729     +329     
- Misses      10842    10854      +12     
Flag Coverage Δ
linux 85.34% <93.27%> (+0.03%) ⬆️
osx 75.19% <93.27%> (+0.07%) ⬆️
other 85.52% <93.27%> (+0.03%) ⬆️
win 82.61% <93.27%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelbynum
Copy link
Contributor Author

Assuming tests pass, this should be ready to go now.

@blnicho blnicho self-requested a review September 5, 2023 18:57
@michaelbynum michaelbynum merged commit d960c57 into Pyomo:main Nov 27, 2023
30 checks passed
@michaelbynum michaelbynum deleted the wntr branch February 25, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants