Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
This PR fixes the following issues:
fs.wrap.WrapReadOnly
did not wrap theremovetree
method, meaning a filesystem could still be wiped if this command was called. Closes WrapReadOnly does not wrapremovetree
#468 .fs.wrap.WrapCachedDir
methodsisdir
andisfile
would raiseResourceNotFound
instead of returningFalse
on non-existing paths.I also added more tests for these two classes, and in particular a test making sure
fs.copy
,fs.move
andfs.mirror
respectWrapReadOnly
semantics; this is to avoid any new undetected removal that could occur if #429 or similar improvements are added which could useos
functions to improve performance in various places when given filesystems with a syspath.