Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for formato_json.py module #155

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ABHISHEKSONI121
Copy link
Collaborator

@ABHISHEKSONI121 ABHISHEKSONI121 commented Jun 10, 2024

Test Suite Summary for formato_json Module

Coverage

Key Achievements

  • 14 tests passing
  • Comprehensive testing for leer and escribir functions
  • Covers JSON file reading, writing, and data manipulation
  • Includes edge cases and exception handling

Manual test evidence

finalllll

Checklist

  • Classes, Variables, function and methods logic ok
  • Comments written explaining what the code does
  • All python code is PEP8 compliant (run black .)
  • No lint issues (run flake8)
  • Test coverage with pytest implemented
  • Reviewers assigned (at least 1 mentor)

🔗 Related Issues

Closes #164: Improve test coverage for formato_json module


💡 This test suite provides excellent coverage for the formato_json module. It demonstrates the reliability and robustness of the JSON processing functionality in PyAfipWs.

Signed-off-by: SONIABHISHEK121 <[email protected]>
Signed-off-by: SONIABHISHEK121 <[email protected]>
import tempfile

@pytest.mark.dontusefix
class TestFormatoJSON(unittest.TestCase):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ABHISHEKSONI121 Could you write the test with pytest? You could use the pytest tmp_path fixture for this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for that
I have updated the tests and also ran black and flake8 before committing as you asked

Signed-off-by: SONIABHISHEK121 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants