Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing v1.0.0 #56

Merged
merged 46 commits into from
May 10, 2024
Merged

Releasing v1.0.0 #56

merged 46 commits into from
May 10, 2024

Commits on Feb 5, 2024

  1. Configuration menu
    Copy the full SHA
    e2a64ac View commit details
    Browse the repository at this point in the history
  2. Merge pull request #38 from ProjectTorreyPines/fix_pfr_split

    Bugfix: fix PFR split in extended mesh
    anchal-physics authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    e1e6a36 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. Configuration menu
    Copy the full SHA
    58148eb View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Merge pull request #40 from ProjectTorreyPines/docs

    Added link for adding ssh-key to Github
    anchal-physics authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    e6bb21f View commit details
    Browse the repository at this point in the history
  2. Updating use of solp2imas

    PR ProjectTorreyPines/SOLPS2imas.jl#24
    will change gsdesc to a keyword argument with default file. This
    commit changes all use cases of solp2imas to use the default
    gsdesc value instead of supplying a file. This is in support of
    closing
    #33
    anchal-physics committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    32e649a View commit details
    Browse the repository at this point in the history
  3. Adding makefile for building toml files

    Added makefile that correctly clones repos or use git urls to generate
    a functioning set of toml files so that private projects can be
    accessed easily.
    anchal-physics committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    839d367 View commit details
    Browse the repository at this point in the history
  4. Updated

    README with make instructions
    anchal-physics committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    d4c1c7d View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Merge pull request #42 from ProjectTorreyPines/make

    Adding makefile for building Julia environment
    anchal-physics authored Feb 16, 2024
    Configuration menu
    Copy the full SHA
    ea7308f View commit details
    Browse the repository at this point in the history
  2. Merge pull request #41 from ProjectTorreyPines/solps2imas_update

    Updating use of solp2imas
    anchal-physics authored Feb 16, 2024
    Configuration menu
    Copy the full SHA
    4114ca1 View commit details
    Browse the repository at this point in the history
  3. Add a simple demo

    eldond committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    b4c4ffa View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Fix simple demo

    eldond committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    09933c3 View commit details
    Browse the repository at this point in the history
  2. During preparation, try to add rho to equilbrium

    - The function for adding rho doesn't act if rho is already present and valid
    - Some G-files don't have rho or have all 0s, which is invalid and not useful
    eldond committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    54857bf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c4c37ab View commit details
    Browse the repository at this point in the history
  4. Formatting compliance

    eldond committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    d2aff2f View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Change the cache file so it doesn't exceed the file name file system …

    …limit.
    +Alicia Dautt-Silva committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    bcc83ac View commit details
    Browse the repository at this point in the history
  2. Merge pull request #46 from ProjectTorreyPines/simple_jl_demo

    Add a simple demo
    eldond authored Feb 23, 2024
    Configuration menu
    Copy the full SHA
    a4a8e74 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. makefile clones without .jl in .julia/dev and more

    make r option now checks if it is called from inside a repo that is
    present in .julia/dev and if present there, it clones the dependent
    repos without the .jl extension.
    
    It also runs dvc pull to ensure sample files have been pulled
    anchal-physics committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    b20b250 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Fixed formatting

    anchal-physics committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    8e2b0a5 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #47 from ProjectTorreyPines/make

    makefile clones without .jl in .julia/dev and more
    anchal-physics authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    e2c8cb8 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Configuration menu
    Copy the full SHA
    18f6a47 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #49 from ProjectTorreyPines/handle_gsi_change

    Adding option to specify cell subset index
    
    Merging as ProjectTorreyPines/SOLPS2imas.jl#30 as been merged.
    anchal-physics authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    39a7ab8 View commit details
    Browse the repository at this point in the history
  3. Update demo.ipynb

    Updating the name of the get_grid_subset (old get_grid_subset_witg_index)
    dautt-silva authored and anchal-physics committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    de5a689 View commit details
    Browse the repository at this point in the history
  4. Updating the name of the get_grid_subset (old get_grid_subset_witg_in…

    …dex)
    +Alicia Dautt-Silva authored and anchal-physics committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    243f324 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    570cf41 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Replacing OMAS with IMASDD everywhere

    Tested this but got following error:
    ```
    (base) gupta@F-CJXNMY7L7 SD4SOLPS.jl % julia --project test/runtests.jl
    Test Summary:         | Pass  Total  Time
    lightweight_utilities |    4      4  1.0s
    Test Summary: | Pass  Total  Time
    actuator      |    2      2  1.7s
    core_profile_extension: Error During Test at /Users/gupta/Git/ProjectTorreyPines/SD4SOLPS.jl/test/runtests.jl:166
      Got exception outside of a @test
      UndefVarError: `gradient` not defined
      Stacktrace:
       [1] extrapolate_core(edge_rho::Vector{Float64}, edge_quantity::Vector{Float64}, rho_output::Vector{Float64})
         @ SD4SOLPS ~/Git/ProjectTorreyPines/SD4SOLPS.jl/src/supersize_profile.jl:58
       [2] macro expansion
         @ ~/Git/ProjectTorreyPines/SD4SOLPS.jl/test/runtests.jl:171 [inlined]
       [3] macro expansion
         @ /Applications/Julia-1.9.app/Contents/Resources/julia/share/julia/stdlib/v1.9/Test/src/Test.jl:1498 [inlined]
       [4] top-level scope
         @ ~/Git/ProjectTorreyPines/SD4SOLPS.jl/test/runtests.jl:168
       [5] include(mod::Module, _path::String)
         @ Base ./Base.jl:457
       [6] exec_options(opts::Base.JLOptions)
         @ Base ./client.jl:307
       [7] _start()
         @ Base ./client.jl:522
    Test Summary:          | Error  Total  Time
    core_profile_extension |     1      1  0.5s
    ERROR: LoadError: Some tests did not pass: 0 passed, 0 failed, 1 errored, 0 broken.
    in expression starting at /Users/gupta/Git/ProjectTorreyPines/SD4SOLPS.jl/test/runtests.jl:165
    ```
    
    For testing, following versions of the pacjages were used (these are the points where IMASDD was used instead of OMAS):
    GGDUtils: ProjectTorreyPines/IMASggd.jl@b11ad15
    SOLPS2IMAS: ProjectTorreyPines/SOLPS2imas.jl@f843e6a
    
    The main issue is that OMAS.gradient() function is defined in https://github.com/ProjectTorreyPines/OMAS.jl/blob/master/src/math.jl
    but no such function exists in IMASDD.
    anchal-physics committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    3597a61 View commit details
    Browse the repository at this point in the history
  2. Using readg() with set_time & conformed to IMASDD

    Using set_time for sample files where description is not in the
    standard format.
    
    Changes were made in the code to use ismissing in places to conform to
    requirements of IMASDD.
    
    In record_regular_mesh!(), the deepcopy of each element was replaced
    with deepcopy of the entire grid subset to improve speed.
    
    The test runtests.jl was updated to reflect the changes.
    
    All tests pass now with following versions:
    
    JuliaFusion/EFIT.jl@8580ca8
    ProjectTorreyPines/IMASdd.jl@6a6968a
    ProjectTorreyPines/IMASggd.jl@b11ad15
    ProjectTorreyPines/SOLPS2imas.jl@f843e6a
    
    Note that EFIT version that was used has not been merged with its
    master branch yet at the time of this test.
    
    In conclusion, in future, OMAS can be removed now.
    anchal-physics committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    864319e View commit details
    Browse the repository at this point in the history
  3. Putting back OMAS

    anchal-physics committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    c7c3c1e View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    c614b8b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #50 from ProjectTorreyPines/omas_imas

    Replacing OMAS with IMASDD everywhere
    anchal-physics authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e4cebf2 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Final change from OMAS to IMASDD

    The final change from OMAS to IMASDD is now complete. The code has been
    tested and is working. For this repo, there was no change in the
    speed of the code.
    anchal-physics committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    9d22300 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Merge pull request #51 from ProjectTorreyPines/omas_imas

    Final switch to IMASDD
    anchal-physics authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    167fc8b View commit details
    Browse the repository at this point in the history
  2. make r will clone repo without .jl extension

    Now make r will clone dependent project repos without the .jl extension
    by default. The unnecessary complexity of detection of .julia/dev path
    has been removed. This is to address ProjectTorreyPines/SOLPS2imas.jl#33
    anchal-physics committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    b1cab8d View commit details
    Browse the repository at this point in the history
  3. Updated example demo and simple_demo with new makefile

    demo.ipynb and simple_demo.jl had become out of date because of recent
    changes. Also, the demo envrionment creation was not good and used shell
    scripts. This commit, uses new makefile that cleanly creates a set of
    Porject.toml and Manifest.toml files that will work with demo. The
    sample files are also sources from SD4SOLPS.jl/sample now.
    anchal-physics committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    8c075cf View commit details
    Browse the repository at this point in the history
  4. Merge pull request #52 from ProjectTorreyPines/make

    makefile and examples updated
    
    Simple fix, not asking for review.
    anchal-physics authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    ce61602 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Using TPS interpolation to get midplane profile

    For core profile extrapolation, the property needs to be evaluated at
    the midplane surface. This is done by interpolating the property at the
    midplane surface using the TPS interpolation method now. Earlier, it
    was using KDTree method which was creating a very flat electron density
    profile near the core boundary.
    anchal-physics committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    f80ae37 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Merge pull request #53 from ProjectTorreyPines/fix_core_extp

    Using TPS interpolation to get midplane profile
    anchal-physics authored May 1, 2024
    Configuration menu
    Copy the full SHA
    615820f View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Cleanup and documentation

    * core_profiles_2d has been removed as GGDUtils.interp provides the same functionality
    * The actuator_model.jl has been moved to unit_utils.jl with only unit conversion utilities. SynthDiag.compute_gas_injection provides gas actuation model directly from IMAS dd now.
    * All functions have strict input and output types defined.
    * All docstrings have been updated to be more informative.
    * Tests have been updated and cleaned up a bit.
    * Examples have been updated with simplified package addition. No make file required inside examples directory anymore.
    anchal-physics committed May 9, 2024
    Configuration menu
    Copy the full SHA
    7f8c1a6 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #54 from ProjectTorreyPines/docs

    Cleanup and documentation
    anchal-physics authored May 9, 2024
    Configuration menu
    Copy the full SHA
    73349e8 View commit details
    Browse the repository at this point in the history
  3. Adding CI testing

    Triggered at:
    
    * For pushing changes to master or dev branches
    * For pull requests to master or dev branches
    
    Features:
    
    * Uses Julia 1.9.3 (we can change or increase number of versions to be tested and supported later)
    * Uses ubuntu-latest in x86 architecture
    * Uses DVC to pull sample files (login to cybele using guptaa account)
    * Runs test using julia's native test feature.
    * Uploads generated images in test results to the artifacts.
    * CodeCov needs to be setup for reporting code coverage of the tests.
    anchal-physics committed May 9, 2024
    Configuration menu
    Copy the full SHA
    828a0ee View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1d691f2 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #55 from ProjectTorreyPines/autotest

    Adding CI testing
    anchal-physics authored May 9, 2024
    Configuration menu
    Copy the full SHA
    7760e80 View commit details
    Browse the repository at this point in the history
  6. Releasing v1.0.0

    * Now depends on IMASDD. All previous versions depend on OMAS and will be deprecated.
    * Apache 2.0 licence with notice file
    * Added documentation
    * Added tests
    anchal-physics committed May 9, 2024
    Configuration menu
    Copy the full SHA
    a936096 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d319f1a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8d32a7f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    aeb0c0f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    329f0cf View commit details
    Browse the repository at this point in the history