Quick bug fix #20
Merged
Quick bug fix #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project_prop_on_subset was not working properly when the property
values are not tagged as values but some other name. Added a new
argument for that.
Also notices that interp(prop_values::Vector{T}, space::OMAS.edge_profiles__grid_ggd___space)
had a typo in return call and would have failed.
In project_prop_on_subset!, when the dimensions of to_subset is lower, then an interpolation is required. This commit adds an option to choose between thin plate spline (:thin_plate_spline) (slower, more accurate) and using KD trees (:kd_tree) (faster, less accurate).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project_prop_on_subset was not working properly when the property values are not tagged as values but some other name. Added a new argument for that.
Also notices that interp(prop_values::Vector{T}, space::OMAS.edge_profiles__grid_ggd___space) had a typo in return call and would have failed.