Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pod assignment issue when pod already has a node assigned #564

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

chaunceyjiang
Copy link
Contributor

@chaunceyjiang chaunceyjiang commented Oct 21, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix pod assignment issue when pod already has a node assigned
Which issue(s) this PR fixes:
Fixes #488

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 27.09% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/scheduler/webhook.go 56.00% <100.00%> (+9.19%) ⬆️

@chaunceyjiang
Copy link
Contributor Author

/cc @wawa0210 @archlitchi @lengrongfu PTAL.

@wawa0210
Copy link
Member

Codecov Report

Can you solve the Codecov Report UT coverage issue?

@chaunceyjiang
Copy link
Contributor Author

Can you solve the Codecov Report UT coverage issue?

Done.

@lengrongfu
Copy link
Member

/LGTM

@wawa0210
Copy link
Member

/lgtm thanks your contribution

@wawa0210 wawa0210 merged commit b0873aa into Project-HAMi:master Oct 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When use set nodeName field, should skip hami-scheduler, this will not trigger the scheduling logic
3 participants