Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting libcuda verbosity #563

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

4gt-104
Copy link
Contributor

@4gt-104 4gt-104 commented Oct 19, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add support for setting LIBCUDA_LOG_LEVEL during admission.

Which issue(s) this PR fixes:
Resolves: #544

Special notes for your reviewer:
I added a new function, setOrUpdateEnvVar, as I couldn’t find an existing alternative in the source code. However, I believe it should be placed in a more accessible location other than pkg/device/nvidia/device.go.

Does this PR introduce a user-facing change?:
Default log level stays the same.
Users should upgrade their values.yaml files if they want to change verbosity level.

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/device/nvidia/device.go 47.05% 8 Missing and 1 partial ⚠️
Flag Coverage Δ
unittests 27.10% <47.05%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/device/nvidia/device.go 33.94% <47.05%> (+2.36%) ⬆️

@4gt-104 4gt-104 marked this pull request as draft October 20, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a way to reduce the HAMI-Core verbosity level for workloads?
1 participant