Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render Embedded Zap Amount #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MerryOscar
Copy link

Currently if someone embeds a zap kind 9735 in a note using the nostr:nevent1... encoding, a note embed card is rendered but there is no information about the zap.

This PR is a simple improvement that adds the zap amount by parsing it from the embedded description tag in the zap.

The sender pubkey is also available so the sender profile could be rendered as well - although I was unsure how to get the PrimalUser class from the sender pubkey.

Before

fountain-embedded-zap-current

After

primal-embedded-zap-with-amount

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant