Don't try to delete a cronjob if does'nt exist #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camlafit
commented
Nov 30, 2018
camlafit
commented
- solve Notice on disable module #44
PierreRambaud
approved these changes
Nov 30, 2018
|
Hello @camlafit Thank you for this PR. Can you provide me a module in order to test your PR ? Thank you |
|
Hello As explained #44 any module can have this problem. To any reason an admin can remove hook from BO and broke cron related. |
|
@sarahdib What is the reason to remove the Waiting for QA? |
PierreRambaud
approved these changes
Oct 15, 2019
|
Hey, just notice your target the wrong branch. Can you rebase your branch please? |
PierreRambaud
suggested changes
Oct 15, 2019
|
Hello code was rebased on dev |
PierreRambaud
approved these changes
Oct 21, 2019
|
Thanks @camlafit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.