better common error section #15271
Merged
better common error section #15271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
requested review from
discdiver,
cicdw and
desertaxle
as code owners
cicdw
requested changes
Sep 7, 2024
cicdw
approved these changes
Sep 7, 2024
jlowin
approved these changes
Sep 7, 2024
| For example, `my_task.submit(...)` is _always_ synchronous in Prefect 3.x: | ||
|
|
||
| <CodeGroup> | ||
| ```python Wrong |
There was a problem hiding this comment.
This is such a small nit but if this is "Wrong" I'd expect the other tab to be "Right." If the other tab is "Correct" I'd expect this one to be "Incorrect."
|
Thank you for updating @zzstoatzz! |
zzstoatzz
commented
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14996 removed this section because the code example was distracting and detracted from the main point, which was to make sure these common errors are searchable and have concrete suggestions to resolve them
this PR reintroduces the section with the intent of being more clear about what to change / why this is happening