Add support for WaterdogPE xuid and IP #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alikindsys
added
Status: Awaiting Review
LoboMetalurgico
added
the
Needs: Ingame Testing
|
Please open a pull request for |
alikindsys
added
Status: Awaiting Response
|
Sorry, didn't realize that languages were handled differently on power-nukkit vs cloudburst's nukkit. I've went ahead and just added the option to default-nukkit.yml instead. |
|
I think it would look cleaner if you rename Waterdog_IP and Waterdog_XUID to waterdogIP and waterdogXUID |
LoboMetalurgico
added
Status: Awaiting Review
|
Hello, thanks for your Pull Request. Our team will make a small change to the isWaterdog function, where we will move it to the server class, so that we can expose it to the plugins. You don't have to worry about anything and we thank you for making this implementation! |
alikindsys
approved these changes
Jul 3, 2022
LoboMetalurgico
added
Resolution: resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
Waterdog_XUIDandWaterdog_IPfields in the ClientChainData when settings.waterdogpe is true. The functionality is similar to how Spigot deals with Bungeecord.As there were changes to theShouldn't be needed for PowerNukkitlangfolder, commitf6f851bwould also need to be merged.This is the same PR as
CloudburstMC/Nukkit#1986, just adapted to PowerNukkit.