Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.1.0 Pre-Mainnet simulation #25

Merged
merged 14 commits into from
Jul 17, 2024
Merged

v1.1.0 Pre-Mainnet simulation #25

merged 14 commits into from
Jul 17, 2024

Conversation

anomit
Copy link
Member

@anomit anomit commented Jul 17, 2024

Issues addressed in PR #23 which also ensured testing of the build and publishing of the docker image.

Checklist

  • My branch is up-to-date with upstream/develop branch.
  • Everything works and tested for Python 3.8.0 and above.
  • I ran pre-commit checks against my changes.
  • I've written tests against my changes and all the current present tests are passing.

Current behaviour

Described in PR #23

New expected behaviour

Same as above

Change logs

Refer PR #23

Deployment Instructions

Refer to the appropriate section in README

@anomit anomit self-assigned this Jul 17, 2024
@anomit anomit marked this pull request as ready for review July 17, 2024 06:54
@anomit anomit requested a review from muku314115 July 17, 2024 06:56
xadahiya

This comment was marked as outdated.

Sign in to view

@xadahiya xadahiya self-requested a review July 17, 2024 07:30
xadahiya
xadahiya approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@xadahiya xadahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after latest build process improvements!

SwaroopH
SwaroopH approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@SwaroopH SwaroopH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anomit anomit merged commit ffa7496 into main Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwaroopH SwaroopH SwaroopH approved these changes

@xadahiya xadahiya xadahiya approved these changes

@Seth-Schmidt Seth-Schmidt Awaiting requested review from Seth-Schmidt

@muku314115 muku314115 Awaiting requested review from muku314115

Assignees

@anomit anomit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anomit @SwaroopH @xadahiya